[1.x] Fix phpstan and commerce plugin contructors

Created on 20 March 2025, 17 days ago

Problem/Motivation

📌 Fix phpstan and commerce plugin contructors Active fixed the commerce plugin constructors for 2.x, but not for 1.x. Let's fix 1.x as well while it is still supported.

Steps to reproduce

Install email_registration with Drupal Commerce 3.x

Proposed resolution

Fix phpstan and commerce plugin contructors

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇳🇱Netherlands idebr

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @idebr
  • 🇨🇦Canada danrod Ottawa
  • 🇨🇦Canada danrod Ottawa
  • Merge request !57Resolve #3514271 "1.x fix phpstan" → (Open) created by danrod
  • Pipeline finished with Failed
    17 days ago
    Total: 133s
    #453159
  • Pipeline finished with Failed
    17 days ago
    Total: 344s
    #453163
  • Pipeline finished with Failed
    17 days ago
    Total: 329s
    #453171
  • Pipeline finished with Failed
    17 days ago
    Total: 324s
    #453197
  • 🇨🇦Canada danrod Ottawa
  • Pipeline finished with Failed
    17 days ago
    Total: 339s
    #453202
  • 🇨🇦Canada danrod Ottawa
  • Pipeline finished with Failed
    17 days ago
    Total: 342s
    #453211
  • Pipeline finished with Failed
    17 days ago
    Total: 377s
    #453233
  • 🇨🇦Canada danrod Ottawa
  • 🇨🇦Canada danrod Ottawa

    I fixed some of the PHPSTAN / PHPCS / CSPELL issues, but I'm having issues with the tests regarding my changes that I don't see in my instance (10.3.11):

    TypeError: Drupal\email_registration\Plugin\Action\UpdateUsernameAction::__construct(): Argument #1 ($logger_factory) must be of type Drupal\Core\Logger\LoggerChannelFactoryInterface, array given, called in /builds/issue/email_registration-3514271/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php on line 25

  • Pipeline finished with Failed
    17 days ago
    Total: 293s
    #453243
Production build 0.71.5 2024