- Issue created by @mstrelan
- Merge request !11549Issue #3514226: Add void return to functions in global namespace β (Open) created by mstrelan
- πΊπΈUnited States smustgrave
Believe there are 2 more instances
1) core/themes/claro/claro.theme:1412
---------- begin diff ----------
@@ @@
* The renderable array of image and file widgets, with 'element' and 'data'
* keys.
*/
-function _claro_preprocess_file_and_image_widget(array &$variables) {
+function _claro_preprocess_file_and_image_widget(array &$variables): void {
$element = $variables['element'];
$main_item_keys = [
'upload',
----------- end diff -----------Applied rules:
* AddFunctionVoidReturnTypeWhereNoReturnRector2) core/tests/Drupal/Tests/Core/Extension/modules/module_handler_test/hook_include.inc:9
---------- begin diff ----------
@@ @@
/**
* Test hook.
*/
-function module_handler_test_hook_include() {
+function module_handler_test_hook_include(): void {
}
----------- end diff -----------Applied rules:
* AddFunctionVoidReturnTypeWhereNoReturnRectorIf you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- π¦πΊAustralia mstrelan
Thanks for checking and reporting those, not sure why they were missed.
- π³πΏNew Zealand quietone
For some reason, the lastest diff doesn't include the changes in "1f8a5746 - Stragglers". And there are conflicts in the baseline.
-
quietone β
committed 5da58a21 on 11.x
Issue #3514226 by mstrelan, smustgrave: Add void return to functions in...
-
quietone β
committed 5da58a21 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.