Add void return to functions in global namespace

Created on 20 March 2025, 23 days ago

Problem/Motivation

Split πŸ“Œ Add return type to functions in global namespace Active in to manageable chunks

Steps to reproduce

See parent

Proposed resolution

Run AddFunctionVoidReturnTypeWhereNoReturnRector on module, inc, engine, theme, profile, sh, post_update.php files.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component

other

Created by

πŸ‡¦πŸ‡ΊAustralia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mstrelan
  • Pipeline finished with Failed
    23 days ago
    Total: 552s
    #452862
  • πŸ‡¦πŸ‡ΊAustralia mstrelan
  • Pipeline finished with Success
    23 days ago
    Total: 669s
    #452870
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Believe there are 2 more instances

    1) core/themes/claro/claro.theme:1412

    ---------- begin diff ----------
    @@ @@
    * The renderable array of image and file widgets, with 'element' and 'data'
    * keys.
    */
    -function _claro_preprocess_file_and_image_widget(array &$variables) {
    +function _claro_preprocess_file_and_image_widget(array &$variables): void {
    $element = $variables['element'];
    $main_item_keys = [
    'upload',
    ----------- end diff -----------

    Applied rules:
    * AddFunctionVoidReturnTypeWhereNoReturnRector

    2) core/tests/Drupal/Tests/Core/Extension/modules/module_handler_test/hook_include.inc:9

    ---------- begin diff ----------
    @@ @@
    /**
    * Test hook.
    */
    -function module_handler_test_hook_include() {
    +function module_handler_test_hook_include(): void {
    }
    ----------- end diff -----------

    Applied rules:
    * AddFunctionVoidReturnTypeWhereNoReturnRector

    If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

  • πŸ‡¦πŸ‡ΊAustralia mstrelan

    Thanks for checking and reporting those, not sure why they were missed.

  • Pipeline finished with Canceled
    19 days ago
    Total: 370s
    #455571
  • Pipeline finished with Failed
    19 days ago
    Total: 624s
    #455575
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Thanks! LGTM

  • πŸ‡³πŸ‡ΏNew Zealand quietone

    For some reason, the lastest diff doesn't include the changes in "1f8a5746 - Stragglers". And there are conflicts in the baseline.

  • Pipeline finished with Success
    19 days ago
    Total: 477s
    #455768
  • Pipeline finished with Success
    19 days ago
    Total: 784s
    #455779
  • πŸ‡¦πŸ‡ΊAustralia mstrelan

    Have rebased and restored the stragglers

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Rebase seems good

  • πŸ‡¬πŸ‡§United Kingdom MrDaleSmith

    looks good and works for me.

    • quietone β†’ committed 5da58a21 on 11.x
      Issue #3514226 by mstrelan, smustgrave: Add void return to functions in...
  • πŸ‡³πŸ‡ΏNew Zealand quietone

    Committed 5da58a2 and pushed to 11.x.

    Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024