- Issue created by @danielveza
- π³πΏNew Zealand danielveza Brisbane, AU
MR is up for this and green. Moving to review.
I imagine this will need a CR?
How would we want to handle the removal of this code in D12? Do we wait for this to be committed and open a follow up?
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Reviewed this and checked the property can still be accessed and there is a test to trigger the deprecation.
RTBC once we have a CR.
> I imagine this will need a CR?
Yep.
> How would we want to handle the removal of this code in D12? Do we wait for this to be committed and open a follow up?
I think this would get handled when we make deprecation removal issues when 12.x opens up.
- π³πΏNew Zealand danielveza Brisbane, AU
CR created: https://www.drupal.org/node/3513877 β
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
All good now.
- π³πΏNew Zealand danielveza Brisbane, AU
Feedback addressed and tests are green again
- π¦πΊAustralia mstrelan
Thanks for addressing the isset feedback. I've left one more minor nit but happy to leave at RTBC.
- π³πΏNew Zealand danielveza Brisbane, AU
Addressed feedback, tests are green
- Status changed to Needs work
21 days ago 8:08pm 14 June 2025 - πΊπΈUnited States smustgrave
Sorry but think this missed 11.2, can we update the deprecations for 11.3 please.
What's a recommended way to test this one for when it comes back around.
If you are another contributor eager to jump in, please allow the previous poster(s) at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- π³πΏNew Zealand danielveza Brisbane, AU
Updated the deprecations to 11.3.
In terms of testing this, there isn't a way to do it via the UI but you can create a PHP script that pretty much follows the test coverage in
testNamePropertyDeprecation
and run that withdrush php:script
Something like
$user = new UserSession([ 'name' => 'test', ]); // This should throw a deprecation echo $user->name; echo $user->getAccountName(); $user->foo = 'test'; echo $user->foo; // This should throw an exception echo $user->mail;
- π¦πΊAustralia mstrelan
I was thinking the removal might need to be deferred to 13.x as per π Defer disruptive 11.3 deprecations for removal until 13.0 Active but since
getAccountName
already exists contrib can still support 11.x and 12.x simultaneously by updating to use the getter. - π³πΏNew Zealand danielveza Brisbane, AU
Deprecations updated, tests are green