- Issue created by @danielveza
- 🇳🇿New Zealand danielveza Brisbane, AU
MR is up for this and green. Moving to review.
I imagine this will need a CR?
How would we want to handle the removal of this code in D12? Do we wait for this to be committed and open a follow up?
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Reviewed this and checked the property can still be accessed and there is a test to trigger the deprecation.
RTBC once we have a CR.
> I imagine this will need a CR?
Yep.
> How would we want to handle the removal of this code in D12? Do we wait for this to be committed and open a follow up?
I think this would get handled when we make deprecation removal issues when 12.x opens up.
- 🇳🇿New Zealand danielveza Brisbane, AU
CR created: https://www.drupal.org/node/3513877 →
- 🇳🇿New Zealand danielveza Brisbane, AU
Feedback addressed and tests are green again
- 🇦🇺Australia mstrelan
Thanks for addressing the isset feedback. I've left one more minor nit but happy to leave at RTBC.
