- Issue created by @vijaycs85
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Yeah I think a sub-classed search backend would work. I think a sub-module in this project would make more sense since there would be minimal differences.
- π¬π§United Kingdom vijaycs85 London, UK
thanks! I pushed changes to 2.x at https://git.drupalcode.org/issue/search_api_opensearch-3513714/-/tree/2.... I can't create MR from the fork as I might not have access.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
> I can't create MR from the fork as I might not have access.
Did you click "Get Push Access"?
Also all changes go into 3.x first.
- π¬π§United Kingdom vijaycs85 London, UK
> Did you click "Get Push Access"?
I don't see the button (attached screenshot for reference).
> Also all changes go into 3.x first.
yeah, I have a branch for 3.x I will push it once we have some reviews in place. - π¬π§United Kingdom vijaycs85 London, UK
managed to create MRs directly from the gitlab merge request URL.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Looks like just a few PHPCS errors. Also tagging for Needs Tests. I think it would be good for a test to ensure it all get's wired up correctly.