TypeError: ::findEntityBundleWithField(): $entity_type_id must be of type string, null given

Open on Drupal.org →

Created on 17 March 2025, about 1 month ago

Problem/Motivation

We are getting an error when adding blocks. There is an error in the browser console, "An AJAX HTTP error occurred". Drupal logs have:

TypeError: Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase::findEntityBundleWithField(): Argument #1 ($entity_type_id) must be of type string, null given, called in …/ui_patterns/modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php on line 223 in Drupal\ui_patterns_field_formatters\Plugin\Field\FieldFormatter\ComponentFormatterBase->findEntityBundleWithField() (line 174 of …/ui_patterns/modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php)

Steps to reproduce

In CKEditor, click on the Block button. When "Select content block to embed" appears, choose a block and click "Select blocks". Check the browser console and logs for error messages.

There may be things that are specific to our setup that cause this to happen. However, looking at the code, ComponentFormatterBase::findEntityBundleWithField() requires that its first param is a string. It is called in ::getComponentSourceContexts(). The first param comes from the return value of BaseFieldDefinition::getTargetEntityTypeId(). That function does not promise to always return a string. It may also return NULL, which is what is happening here.

Proposed resolution

Check for a NULL return from BaseFieldDefinition::getTargetEntityTypeId() and handle the case where the value is NULL.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!352TypeError: ::findEntityBundleWithField(): $entity_type_id must be of type string, null given
Merged
🇫🇷France just_like_good_vibes
updated about 1 month ago

Comments & Activities

Issue created by @Liam Morland
Comment about 1 month ago →
🇫🇷France just_like_good_vibes PARIS
Merge request !352Issue #3513546 by just_like_good_vibes: TypeError: ::findEntityBundleWithField(): $entity_type_id must be of type string, null given → (Merged) created by just_like_good_vibes
Comment about 1 month ago →
🇫🇷France just_like_good_vibes PARIS
Hello, thank you for reporting.

When i read for example FieldDefinitionInterface in drupal core, in the comments :
"Returns the ID of the entity type the field is attached to.", "@return string".
But it is not in the signature, only in the comments.

That sounds like a very odd and strange case, where a field formatter would not have an entity_type_id to which it is attached.
i tried to patch the function and treat the case of entity_type_id being null, but my guess is that something else won't work at another place.

please review
Comment about 1 month ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This patch fixed the problem for us. Thanks!
Comment about 1 month ago →
🇫🇷France just_like_good_vibes PARIS
thanks, i will merge
Comment about 1 month ago →
System Message

just_like_good_vibes → committed 30c387fb on 2.0.x
Issue #3513546 by just_like_good_vibes, liam morland: TypeError: ::...
Comment about 1 month ago →
🇫🇷France just_like_good_vibes PARIS
Comment 23 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024