- Issue created by @phenaproxima
- Merge request !776Issue #3511246: Add support for custom sorts to render element → (Merged) created by phenaproxima
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Have zero comments on the code. Looks perfect.
Test coverage it's great too.TBH I don't feel like the block should be able to allow to override the sort labels. Nice that the API provides this though.
A screenshot of 2 PB blocks, one with only ony sorting enabled (so no sort exposed), another one with only 2 sort options enabled:
A screenshot of the validation error after selecting as default a sorting that is not enabled:
The errored field is not highlighted, but has the "has-error" class. So this is a problem with off-canvas styling, not the field error handling here.
-
tim.plunkett →
committed 44ab29c9 on 2.0.x authored by
phenaproxima →
Issue #3511246 by phenaproxima, penyaskito, narendrar: Allow the...
-
tim.plunkett →
committed 44ab29c9 on 2.0.x authored by
phenaproxima →
-
tim.plunkett →
committed 04b4ae6b on 2.0.x
Issue #3511246 by tim.plunkett: Follow-up for last-minute test change.
-
tim.plunkett →
committed 04b4ae6b on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.