Contrib.social

NodeCreationtest::testAuthorAutocomplete has incorrect selector for falsey check

Open on Drupal.org →
Created on 5 March 2025, 29 days ago

Problem/Motivation

Found when tracking down https://www.drupal.org/project/drupal/issues/2233347#comment-16015379 🐛 Unreached test code in ThemeTestSubscriber Active

NodeCreationTest::testAuthorAutocomplete does:

$this->assertSession()->elementNotExists('xpath', '//input[@id="edit-uid-0-value" and contains(@data-autocomplete-path, "user/autocomplete")]');

This would still pass if the user had access to the autocomplete because that path is no longer correct.

Steps to reproduce

Grant access user profiles to the first user in the test
Notice the test still passes

Proposed resolution

Fix the selector.

Remaining tasks

Review
Commit

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

node system

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024