- Issue created by @catch
- πΊπΈUnited States phenaproxima Massachusetts
This seems like a sensible enough change to me.
- π¬π§United Kingdom catch
Another benefit here is that is that if it helps site owners keep modules up to date, it should mean less of a backlog when checking Drupal 12 compatibility when the time comes. Composer doesn't know anything about uninstalled modules so will happily block a major update on something that's not actually in use. At least if everything's up-to-date, or obviously not up-to-date, then it gives the site owner more of a hint on what next steps are.
- First commit to issue fork.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Tests are failing, moving back to needs work.
[config][actions][update.settings]: Config actions cannot be applied to u pdate.settings because the update extension is not installed, and is not in stalled by this recipe or any of the recipes it depends on.
Interesting. I just installed Drupal CMS with only the base recipe and Update was enabled, so I am wondering where it came from.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
drupal_cms_starter requires the automatic_updates module that requires update. Looks like the test/validation doesn't go that deep. I will explicitly add it to be installed.
- πΊπΈUnited States dww
LGTM, but I haven't directly contributed to Drupal CMS config / recipes yet, so I don't feel super qualified to RTBC this.
Only question is if this will still work if the default in core changes, too: π Consider flipping the default for update.settings:check.disabled_extensions Active
- πΊπΈUnited States phenaproxima Massachusetts
Yes, it will work if the default changes. Config actions always do what they say they'll do, regardless of what the config might already be.
-
phenaproxima β
committed 36e35175 on 1.x authored by
thejimbirch β
Issue #3510973 by thejimbirch, catch, dww: Set 'Check for updates of...
-
phenaproxima β
committed 36e35175 on 1.x authored by
thejimbirch β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x, thanks! In the name of caution, not backporting to 1.0.x, but I can be persuaded if there's a strong case for it in the near term.
- πΊπΈUnited States phenaproxima Massachusetts
I think we'll want a change record for this.
- πΊπΈUnited States phenaproxima Massachusetts
Created the change record, it just needs details filled in. https://git.drupalcode.org/project/drupal_cms/-/wikis/Committer-Info/Cha... can be used as a template.
Automatically closed - issue fixed for 2 weeks with no activity.