- Issue created by @mstrelan
- 🇦🇺Australia mstrelan
Quick PoC of an image effect with fallback format. Setting to NR for feedback on the approach, please don't send it back for tests/lint/CR etc.
- 🇦🇺Australia mstrelan
Added a test for when AVIF is supported and another test for the fallback. Added a draft CR. This is ready for review.
- 🇺🇸United States smustgrave
Could the IS get some love. Wouldn't this be considered an API change?
Wonder if a CR is required?
- 🇦🇺Australia mstrelan
Updated the IS to hopefully make it clearer. There is already a CR, are you suggesting it might not be necessary? I think it is useful.
- 🇦🇺Australia mstrelan
Re #5:
Wouldn't this be considered an API change?
It's a new plugin, not a change to an existing one, so no breakage here. You could argue the change to the protected function in GDToolkit is a BC break, but plugins are considered internal and it's a protected method as well, so I don't think it's an issue.
- 🇫🇷France andypost
I find it good/handy feature with CR)
Moreover AVIF is specifically good for big sizes with fallback
- 🇬🇧United Kingdom catch
Moreover AVIF is specifically good for big sizes with fallback
Not necessarily in this issue, could maybe be a follow-up, would we want to consider some kind of configurable filesize threshold where below a certain point we always skip AVIF and use webp instead? Have seen various discussions that decoding AVIF in the browser is a lot more expensive than webp, which can undo the bandwidth savings with smaller images.
- 🇺🇸United States smustgrave
Opened up 📌 Consider falling back to webp based on filesize Active for that discussion.
