Contrib.social

If activating a projects fails and then succeeds on the second try, the error message from the first try is still visible

Open on Drupal.org →
Created on 28 February 2025, about 1 month ago

Problem/Motivation

If you try to activate a project and it fails with an error, and then you try again and it succeeds, you'll still see the error from the first try in the messages area.

Steps to reproduce

Alter ModuleActivator::activate() so that it unconditionally throws an exception, then use Project Browser to install a module that's already in your code base. You'll see the exception message show up in the messages area. Remove the alterations to ModuleActivator, then install the project again. It will succeed (or should), but the error message from the first try will still be there.

Proposed resolution

When an activation error happens, give it a unique identifier -- something like activation_error:fully_qualified_project_id. The Svelte app, when about to activate a project, should then remove the existing message before sending the activation request. Pretty straightforward.

🐛 Bug report
Status

Active

Version

2.0

Component

User experience

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024