Can't use default credential provider without API key/secret

Thanks for reporting @vijaycs85

Can you please confirm the versions of search_api_opensearch and opensearch-project/opensearch-php you are using?

Can you please confirm the versions of search_api_opensearch and opensearch-project/opensearch-php you are using?

drupal/search_api_opensearch:      2.x-dev 
opensearch-project/opensearch-php: 2.4.2

I think this is due to not checking for empty strings when passing the credentials options.

I'm going to postpone this one on 📌 Use \OpenSearch\Aws\SigningClientFactory Active which changes how we create the signing client.

@vijaycs85 would be great if you could test out 📌 Use \OpenSearch\Aws\SigningClientFactory Active and see if it fixes your issues before we commit it.

📌 Use \OpenSearch\Aws\SigningClientFactory Active is in so this is unblocked.

I think this was fixed in 📌 Use \OpenSearch\Aws\SigningClientFactory Active with this code:

    // Set credentials if provided, otherwise fall back to defaults.
    if ('' !== $this->configuration['api_key'] && '' !== $this->configuration['api_secret']) {
      $options['auth_aws']['credentials'] = [
        'access_key' => $this->configuration['api_key'],
        'secret_key' => $this->configuration['api_secret'],
      ];
    }

Because this uses logic in the library, we can only check to see if the 'credentials' array key gets set. See https://github.com/opensearch-project/opensearch-php/blob/main/src/OpenS...

// Check for provided access key and secret.
        if (isset($options['credentials'])) {
            return CredentialProvider::fromCredentials(
                new Credentials(
                    $options['credentials']['access_key'] ?? '',
                    $options['credentials']['secret_key'] ?? '',
                    $options['credentials']['session_token'] ?? null,
                )
            );
        }

        // Fallback to the default provider.
        return CredentialProvider::defaultProvider();

Are you able to manually test this now? If there are issues with the opensearch-php library, feel free to create an issue there too.