Contrib.social

Single date field shows as long event.

Open on Drupal.org →
Created on 27 February 2025, about 1 month ago

Problem/Motivation

When I try to have a very simple content type (event node bundle with title and date field), and I use a past date, the date shows up

Steps to reproduce

  1. Create a new simplytest.me site, standard Drupal install, fullcalendar install
  2. Create a content type called "event" with a "datetime" field on it.
  3. Create an event node with a test title and date, say a few days in the past.
  4. Create a new view of event (Content) nodes, a page display, change the format to "FullCalendar", and add your event date field.
  5. Save your calendar and view it. The event you just created will start on the date you specify, but it will span all the days until the current day.

Proposed resolution

This appears to be related to these lines...

https://git.drupalcode.org/project/fullcalendar/-/blob/3.1.x/src/Plugin/...

Your event will not have an explicit END time, and will be marked as an ALL DAY event because of this. The line $end = new \DateTime(substr($event_end, 0, 10)); assume $event_end is set, but it's actually just an empty string here.

Throwing out an idea that we check if `$event_end` is a blank string, then we instead use `$event_start`?

Remaining tasks

??

User interface changes

??

API changes

??

Data model changes

??

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States dpagini

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dpagini
  • Comment about 1 month ago →
    🇺🇸United States dpagini
  • Merge request !57Resolve #3509432 "Single date field" → (Open) created by dpagini
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 131s
    #435983
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 84s
    #435986
  • Pipeline finished with Failed
    about 1 month ago
    Total: 206s
    #435987
  • Pipeline finished with Success
    about 1 month ago
    Total: 152s
    #435996
  • Comment about 1 month ago →
    🇺🇸United States dpagini

    This MR works for the exact use case I specified, but I'm not sure how it would impact all the other uses of the calendar...

  • Comment about 1 month ago →
    🇺🇸United States dbdrupal

    Thanks @dpagini. I have a use case that is very similar to this, however, there is a default duration for events. We run a youth sports league and all games are an hour in duration. The hour duration is common knowledge so we don't set an end date for the field. However, this doesn't play nice with the current version of FullCalendar. I would like to see (and it used to be there) a default duration added that can be set in the view to tell fullcalendar that if it does not see and end date, to add X number of hours to the start date.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024