- Issue created by @enchufe
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
liam morland → made their first commit to this issue’s fork.
- 🇦🇹Austria klausi 🇦🇹 Vienna
Looks good, thanks!
Uploading stable patch file for composer patches.
PHP 8.4 has been released, and this module is triggering a "use explicit nullable type" deprecation.
This is part of Drupal's coding standards now, but since the issues to fix phpcs in this module have stalled, I'm opening up this issue to fix this single deprecation to avoid the warnings on PHP 8.4.
After updating to PHP 8.4:
FILE: /src/Plugin/migrate/process/DomMigrationLookup.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
128 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $migration.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /src/Plugin/migrate/process/EntityLookup.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
109 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $migration.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /src/Plugin/migrate/process/EntityGenerate.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
62 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $migration.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /src/Plugin/migrate/process/DomApplyStyles.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
89 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $migration.
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /src/Plugin/migrate/destination/Table.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
140 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $migration.
164 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $migration.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /tests/src/Unit/data_fetcher/HttpTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
189 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable instead. Found implicitly nullable parameter: $authenticator.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------liam morland → made their first commit to this issue’s fork.
Looks good, thanks!
Uploading stable patch file for composer patches.