Contrib.social

JS: remove display flex

Open on Drupal.org →
Created on 24 February 2025, about 1 month ago

Problem/Motivation

In js/section-library.js:

if (filterResult) {
  link.parentElement.style.display = 'flex';
} else {
  link.parentElement.style.display = 'none';
}

...
// If no filter is applied, show all links.
filterLinks.forEach(function (link) {
  link.parentElement.style.display = 'flex';
});

I think to show/hide the link, only display none should be put or removed. But no need to put display flex as it will provokes side effects and is not overridable by modules/themes customizing the Section Library links list.

Proposed resolution

Only put or remove display none.

Remaining tasks

🐛 Bug report
Status

Active

Version

2.0

Component

User interface

Created by

🇫🇷France Grimreaper France 🇫🇷

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024