- Issue created by @mherchel
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
I donβt think core ships with a home menu item. If it did, we would have it.
I do think this is a good idea though. I imagine we are setting the home page on site settings, so we should add a menu link for it also.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
MR added that adds a main menu link to Home.
- πΊπΈUnited States phenaproxima Massachusetts
Looks correct in the Tugboat preview, but this seems to have introduced a performance regression: https://git.drupalcode.org/project/drupal_cms/-/jobs/4464103 (I know this issue introduced it because the nightly canary builds do not have this failure).
We should probably see if @catch can offer any quick insight on this. It's entirely possible that the additional assets are legitimate, but we should be sure before we commit this.
- πΊπΈUnited States phenaproxima Massachusetts
Asked @catch in Slack about this, and posting the reply here for anyone who cares to pursue it:
easiest way would be to manually check with and without CSS aggregation enabled and see which CSS file(s) are getting added.
We don't have a way to assert expected libraries per page yet, although that could be nice... - π¬π§United Kingdom catch
I had a quick look - just created a menu item manually.
It's because nav-primary.css, nav-primary-wide.css etc. get loaded by Olivero, because there's a primary menu, whereas previously there was not. So it's working as expected and fine to just update the test assumption.
Opened π Allow assertions on expected libraries for a page Active which theoretically would mean we'd have been able to see exactly what happened in the test failure without having to check manually.
- πΊπΈUnited States phenaproxima Massachusetts
Updated the performance test margins and checked the Tugboat preview to confirm this looks as intended.
-
phenaproxima β
committed c4a53c29 on 1.x authored by
thejimbirch β
Issue #3508446 by thejimbirch, phenaproxima, mherchel, catch, pameeela:...
-
phenaproxima β
committed c4a53c29 on 1.x authored by
thejimbirch β
- πΊπΈUnited States phenaproxima Massachusetts
And, merged into 1.x. Decided against backporting this, since its absence is annoying but not really a "bug" as such.
Automatically closed - issue fixed for 2 weeks with no activity.