- Issue created by @Christian.wiedemann
- 🇫🇷France just_like_good_vibes PARIS
it looks nice, but why is there an implementation in " src/SourcePluginPropValue.php " ?
- 🇩🇪Germany Christian.wiedemann
Because I think we only need this interface only for "widgets". This is also the reason I moved the stuff to a trait. In our class hierachy we don't have a base class for widget. We only have sources with a single value which is in all cases a widget. We don't hit all widgets with thtat logic but for 95%. So other widgets we should think about that in later issues.
- 🇫🇷France just_like_good_vibes PARIS
hello Christian, i guess it is still on your side, ping me when you are ready for review :))
- 🇩🇪Germany Christian.wiedemann
Hi, I reverted all sources which not extends from PropValue. So now we are safe. I think we are ready to merge.
- 🇫🇷France just_like_good_vibes PARIS
sorry, just one small thing about the addRequired for checkbox
-
christian.wiedemann →
committed 7805f830 on 2.0.x
Issue #3508054 by christian.wiedemann, just_like_good_vibes: [2.0.x]...
-
christian.wiedemann →
committed 7805f830 on 2.0.x
Automatically closed - issue fixed for 2 weeks with no activity.