Implement basic features for formatter

The base functionality of the module is ready now and can already be reviewed, but I will keep this issue as "Needs work" right now since I will also write a proper README.md next.

Nice work! I added a few comments. 🙂

I only looked at the code yet and haven't manually tested the module in our dev environment. So once everything is resolved, I can start doing that! 👍

@lrwebks, was this ready for rereview again?

@grevil, the README is still missing, so I'll take care of that and then put the issue to “needs review”.

A last thing that should be done is to take into account different image styles for the local video poster image, so I will do that next before we can call this one done.

This is off to review again, and as far as I can see, done (implementation-wise)!

For final test and review by @thomas.frobieter! 🎉

Back to "NW" based on my comment. Also check our internal vidstack issue on clickup for further comments by @thomas.frobieter.

@lrwebks can you remember why we didn't add a local library endpoint? If we wanted to do it in a follow-up issue, we should create that, but it could also be done here.

@lrwebks the switch case adjustments wasn't fully, what needed to be done. We still had the case, where the poster setting is a valid field, BUT the fields target_id results in being NULL. Fixed that here: https://git.drupalcode.org/project/vidstack_player/-/merge_requests/1/di...

I also reverted the if case logic, so it is a bit more simple to read and we don't have deeply nested if cases.

@lrwebks you forgot to use once, that's why the error appear. Also, we don't actually need to load the external library asynchronous. This probably led to the cache bug.

Yep that fixed the cache issue.

Interesting, if we create an image field on the media entity and let it be displayed. And then use the "rendered entity" display for our media reference field (on e.g. articles) we get the "Uncaught Vidstack Player JS library could not be loaded." error.

I'll create a follow-up issue for that. Not that important as Video Medias usually only display the video anyways.

Ok, we still get occasional issues, that "VidstackPlayer" is not defined, when changing settings. A simple cache clear fixes the issue, but of course this isn't perfect.

I'd say we merge the current status, as this could relate to the cdn using cdn calls internally or something else.

Great work @lrwebks!!

grevil → changed the visibility of the branch revert-08a456be to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.