Help fixing jobs for Admin Toolbar

Hey David! I hope this can help you.

The main reason is that you are pinning the version of the templates to 1.5.10 here https://git.drupalcode.org/project/admin_toolbar/-/blob/3.x/.gitlab-ci.y..., which is fine, but you also need to set an additional variable as mentioned in this page https://project.pages.drupalcode.org/gitlab_templates/info/templates-ver.... You need to set:

variables:
  _CURL_TEMPLATES_REF: "1.5.10"

So the scripts and the assets downloaded with it match, otherwise you are running some things from 1.5.10 together with some things from the latest version.

The above might be enough to at least have the templates try to run the expected versions, but might not have some of the many fixes that were fixed between 1.5.10 and the latest version. See the changelog here https://git.drupalcode.org/project/gitlab_templates/-/blob/main/CHANGELO...

--

An alternative way of getting the templates to run is to use the defaults in

  - project: $_GITLAB_TEMPLATES_REPO
    ref: $_GITLAB_TEMPLATES_REF

And then to have Drupal 10 as "default" you can customise the DRUPAL_CORE variable as shown in this example: https://project.pages.drupalcode.org/gitlab_templates/info/customization...

composer:
  variables:
    DRUPAL_CORE: 10.4.1

Éither way should help you with these inconsistencies.

Super nice Fran! As usual, you rock! 🤩

Thanks a lot for taking the time to look into this and for all the info you have provided! 🙏
It's super helpful!

At this point, I've only tested just reverting this one line you've pointed, which pins the template version ...
Really not sure why this was needed in the first place, I'll look into this a bit later (the commits, tickets, etc...).

Reverting this line allowed all the jobs to go through properly! Thanks a lot Fran!
https://git.drupalcode.org/issue/admin_toolbar-3466125/-/pipelines/429702

It seems I'm getting a PHPUnit error now, which is really great!! 😅
Looks like we've got some compatibility testing and fixing to do for D11.

I'm going to keep working on fixing these tests + the config file and let you know if I'm still having any issues ...

But supposedly, I "should" be able to take it from here!

Glad to see you're doing great!
Cheers Fran! 🙂

Glad to hear that the above got you unblocked!

The reason for that extra variable is:
- Short(ish) version: sometimes, as part of the job, we need to download supporting files from the gitlab_templates repo, and if you don't set up that variable, it will download them from the latest (recommended) version. Cspell and phpstan need to download configuration files if the project doesn't have any. So by setting _CURL_TEMPLATES_REF to the same version as ref then you are fully pinning the version of the downloaded files too.
- Long version: 🐛 _GITLAB_TEMPLATES_REF value in variables needs updating, and provide override variables for Curl Fixed

Thanks a lot Fran, once again!

It's super nice of you to take the time to provide more information on the options we could possibly consider 🙂.
I've learnt quite a lot of things and hopefully will be able to debug a little bit better these types of issues by myself next time 👍.

I just wanted to give you some feedback on the issue:

The complete report is here: 📌 Fix GitLab CI configuration causing jobs to fail with warnings Active

In the end, I've just reverted back to using the default template, which I think is what we really want:
We do want to have warnings or errors reported by jobs with deprecation validation, messages on standards changing, etc.... when stable/supported versions change.

If that doesn't fit the module in the long run, we could still move back to implementing a solution based on the options you provided in this ticket 👌

Accepted merge request: https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/115

Module's pipelines: https://git.drupalcode.org/project/admin_toolbar/-/pipelines
See the change with the stages going from 2 warnings down to 1, as it used to be, before the template version was pinned.

As far as our module is concerned, the problem can be considered Fixed!! 🥳

I just wanted to say how impressed I am with the progress that has been made over the last couple of years on the Gitlab CI side and more particularly with all the work you've been pulling though!
I saw the documentation as well has greatly improved and is really great now: 🤩
https://project.pages.drupalcode.org/gitlab_templates/

Thanks again so much for all the great work, patience, kindness and amazing reactivity!
Looking forward to getting in touch with you again soon!
Cheers!

Thanks for the kind words David! It has definitely come a long way, but it wasn't just me, shout out to @jonathan1055 and all the rest of the community who are constantly helping things move forward, both code and documentation!