- Issue created by @wim leers
- Merge request !668Resolve #3507704 "Componenttreeitem get phpstan" β (Merged) created by wim leers
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
OR leverage PHPStan infrastructure: https://phpstan.org/developing-extensions/dynamic-return-type-extensions
This seemed overkill, but the top of that page links to https://phpstan.org/developing-extensions/dynamic-return-type-extensions, which seems very doable. Just gave that a try in the MR I opened π€
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
That worked!
Let's see how much clean-up this enablesβ¦ π€
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
wim leers β credited larowlan β .
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Finishing this up, given @larowlan's MR approval.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Bizarre e2e test failures, with completely white screenshots of failures π€ͺ Seems like a very deep Cypress or Chrome fail β¦ Re-running.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This then also conflicted with π Remove ComponentTreeMeetsRequirementsConstraint::$nested Active , which just landed, but it also allowed even more clean-up.
Final tally:
12 files, +26, β59
π Not a great deal, but I know several people working on XB got turned around over these β so it's nice to get that out of the way. -
wim leers β
committed 9951ebee on 0.x
Issue #3507704 by wim leers, larowlan: PHPStan conditional return type...
-
wim leers β
committed 9951ebee on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.