Can't edit existing tokens after beta1 update

We are having the same issue, and hopefully providing more context and maybe some code ideas soon.

We have a bunch of tokens with underscores created over many years, inside of blocks, paragraphs, nodes and used across thousands of pages + revisions. I'm not sure why underscores are suddenly no longer allowed. We cannot edit content inside these existing tokens, so we are going to downgrade to an older version of this module before this unexpected forced formatting was created.

Version 8.x-1.0-alpha5 worked. This issue should be reverted for now: https://www.drupal.org/project/token_custom/issues/3093275 🐛 Token (& token type) machine name requirements RTBC

The RTBC'd MR in 🐛 Token (& token type) machine name requirements RTBC was wrong, it didn't allow for underscores, we should fix this and release a hotfix. Help appreciated.

Please have a look at the quickfix and give it a try. Does it fix the issue?

Confirmed the commit from #6 fixes this issue against the latest beta.

@grevil: Would you be so kind then to merge and tag a new release?

Thank you all and sorry I didn't see that flaw.

Merged! Unfortunately, I didn't realise the commit MR title wasn't adjusted. Hence it won't be linked here.

@anybody and @grevil - just wanted to ask about the rest of the issue with this fix: Are all new tokens going to continue to require the use of dashes?

I feel like this is not a great user experience to randomly switch and have old tokens using underscores while new ones use dashes. I'm worried this will be confusing for our users, but also understand that we're trying to make some progress with this module and get it updated and such.

Thanks again for the fixes so far!

@agbuckus, when testing the latest beta2, I'm able to add new tokens using underscores. The check now allows underscores for new tokens as well as existing it seems.

Exactly. Forcing dashes was an unexpected and unwanted regression.

Automatically closed - issue fixed for 2 weeks with no activity.