- Issue created by @Grevil
- Merge request !2Issue #3507443: Instead of using the best rate's amount, use the best rate itself β (Merged) created by Grevil
- π©πͺGermany Grevil
I suggest a 2.x release, as this won't break any existing installations, but the module will behave completely different.
- π©πͺGermany Grevil
Talked with @rhovland via Slack, he would like to have this be a configurable feature. So I am doing that now.
- π©πͺGermany Grevil
Alright, the new feature is now configurable and works like a charm! ππ
Now, that the setting is configurable on best rate plugin level via checkbox, we are also able to do a mixture of both approaches (if we want)!
Here is a quick screenshot of the new checkbox (not liking the description text yet):
And here is a Screenshot of a checkout, using two "best rate" shipping methods. The first has the checkbox enabled and therefore shows the actual rate and the second has the checkbox disabled and therefore shows the "best rate" method:
When checking out, the entities are correctly referenced by the orders shipment entities, so everything is working as intended! π
Please review!
- First commit to issue fork.
- πΊπΈUnited States rhovland Oregon
Looks good, I just need to test it.
How do you feel about the language changes I made to the configuration form?
- πΊπΈUnited States rhovland Oregon
Tested in a site install. Works as expected. Waiting for input on language changes then will commit
- π©πͺGermany Grevil
Thanks for the reply and fixes @rhovland! :)
I added another suggestion to the description of the new form element. This feature is not easy to describe, but maybe you like that one better :)
Otherwise, LGTM! Feel free to merge as is or with adjustments to the description. I think the current wording is good enough, but there is still some tiny room for improvement.
-
rhovland β
committed de6c2b89 on 1.x authored by
grevil β
Issue #3507443: Instead of using the best rate's amount, use the best...
-
rhovland β
committed de6c2b89 on 1.x authored by
grevil β
- π©πͺGermany Grevil
Could you adjust the credits accordingly and create a new release with the changes? :)
- πΊπΈUnited States rhovland Oregon
I'd love to but I'm not exactly sure what "adjust the credits" means
- π©πͺGermany Grevil
The "Add new comment" section has a details wrapper further below the textarea, called "Credits & commiting" where you can give credit to people working on an issue:
- πΊπΈUnited States rhovland Oregon
Ok I think I did credit correctly please double check.