UserCreationTrait::checkPermissions contains unreachable code

Open on Drupal.org →

Created on 17 February 2025, about 2 months ago

Problem/Motivation

Splitting out from https://www.drupal.org/project/drupal/issues/2234295#comment-15699921 🐛 drupalLogin() crashes where it should fail. Postponed: needs info

Steps to reproduce

See code

Proposed resolution

Remove $valid from checkPermissions

Remaining tasks

None

User interface changes

None

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

None

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

user.module

Created by

🇦🇺Australia acbramley

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!11236UserCreationTrait::checkPermissions contains unreachable code
Closed
🇦🇺Australia acbramley
updated about 1 month ago

Comments & Activities

Issue created by @acbramley
Merge request !11236Issue #3507309: Refactor checkPermissions and createRole in UserCreationTrait → (Closed) created by acbramley
Comment about 2 months ago →
🇦🇺Australia acbramley
I considered removing the return entirely but that could cause issues downstream.
Pipeline finished with Success
about 2 months ago
Total: 2791s
#426975
Comment about 2 months ago →
🇺🇸United States smustgrave
Seems straight forward enough.
Comment about 1 month ago →
🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks!
Comment about 1 month ago →
System Message
catch → closed merge request !11236
Comment about 1 month ago →
System Message

catch → committed b68174aa on 11.x
Issue #3507309 by acbramley: UserCreationTrait::checkPermissions...
Comment about 1 month ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024