drupalLogin() crashes where it should fail.

This came up as a daily bugsmash target. Looking at #5 since simpletest has been removed is this still an issue?

When simpletest was removed https://www.drupal.org/node/3091784 →

Checked the methods and yes this still applies to phpunit, as per #32 and #5 we should throw an exception in createRole instead of returning FALSE.

We should start with a reroll of #5 on an MR against 11.x

I created MR that reroll #5 to UserCreationTrait.

Now that I'm actually manually testing the scenario described in the IS I don't think this is a valid bug anymore (see my comment on the MR).

Perhaps at the time this issue was created, we didn't call $this->fail() inside checkPermissions OR as per #32 phpunit halts execution on a fail.

Since we fail when there's an invalid permission, the original issue in the IS does not happen because drupalLogin is never called when an invalid permission is passed through.

Settintg to PMNMI to see if there's other scenarios that we need to account for.

I think this issue should be closed now since it is so old and the original report no longer applies.

I've split the change to checkPermissions out into 🐛 UserCreationTrait::checkPermissions contains unreachable code Active

acbramley → closed merge request !8919