- Issue created by @niklan
- π¦πΊAustralia dpi Perth, Australia
Thanks, I'm finding this produces silly errors in my 11.1 builds also.
Added feedback to MR, otherwise this is a nice quick fix.
- π¬π§United Kingdom alexpott πͺπΊπ
I think we should go with
@param array<mixed>|null $ids
as this is consistent with \Drupal\Core\Entity\EntityStorageInterface::load(), \Drupal\Core\Entity\EntityStorageInterface::loadUnchanged - or we should change those here too... Given the type hint on \Drupal\Core\Entity\EntityInterface::id() is@return string|int|null
I guess the latter option is best. There are test failures which have to be unrelated and known recurring failures. I think this is RTBC otherwise.
- π¨πSwitzerland znerol
I did observe that problem as well. The type hints
string|int
andarray<string|int>|null
are the correct choice. - π¬π§United Kingdom catch
Looks right. Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.