Skip-link not readable if receiving focus

Before

After

Just my 2 small monetary denominations... would it be better to, instead of creating a special case for a single class, to exempt :focus or :focus:focus-visible?

thejimbirch → credited rkoller → .

@rkoller added in slack.

the background spans across the entire viewport that way the skip to main link label is legible again but there is another detail/problem in this context, the a focus outline is not visible like in gin in this case (sc2.4.7). not sure if that is what comment number 5 expresses with “exempt :focus or :focus-visible”?

Moving to Needs work.

That seems out of scope - can we fix it in a separate issue?

I didn't think about the focus outline, but that's a good point. I was thinking more about both code maintenance and other possible unknown cases of this issue. If the exception is on :focus or :focus:focus-visible, then there's no concern if the class name is changed later. Also, it addresses any other case (other than for .skip-link) where this same issue might appear.

@rkoller followed up in slack

yes the focus is probably out of scope of the initial issue and could be fixed in a follow up.

Moving this one back to RTBC.

@aaronpinero , could you create the follow up issue? TIA!

Any reason not to commit this?

None that I can detect. Tests are failing but I don't think it's related. So, merged into 1.x and cherry-picked to 1.0.x. Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.