- Issue created by @bkosborne
- Merge request !42Issue #3506237: Fix parser errors that can occur when rendered tooltip contains certain characters like β (Merged) created by bkosborne
- π΅πΉPortugal joao.ramos.costa
I think the concerning issue should be fixed ASAP or the tooltips are unusable, since with "common" filters any editor may create html entities by pressing 'shift+enters' on (eg) taxonomy term description and the parse errors will be triggered.
- πΊπΈUnited States bkosborne New Jersey, USA
Agreed on getting this in. I fixed the merge conflict in the branch. The CI failures are not from this merge request. The unit tests are passing.
- Status changed to Needs review
20 days ago 8:22am 16 April 2025 - π©πͺGermany Grevil
Great stuff, thanks @bkosborne! Looks good and works great! :)
First, I thought this might have some security implications, as we remove the "html_specialchars" call and therefore let the linked node's / term's / commerce product variation's textarea filter decide what HTML would be allowed.
But that's no problem, as all the "risky" strings are escaped in the twig template anyway! And in the case, where we just reinsert the replaced text (e.g. when "first_only" is checked), we just use the original (HTML) string which was allowed by the currently active filter anyway!
Great work! Merging.
- π©πͺGermany Grevil
Ok, no biggy, the new "ignore_tags" setting was simply missing.
-
grevil β
committed e3d8358f on 3.x authored by
bkosborne β
Issue #3506237: Fix parser errors that can occur when rendered tooltip...
-
grevil β
committed e3d8358f on 3.x authored by
bkosborne β
Automatically closed - issue fixed for 2 weeks with no activity.