Role conditions don't work as expected (OR) if multiple roles are selected

PS: We have to ensure that we don't introduce a new bug then... on top level we want the AND, just within the separate conditions we want the OR?

Time for a nestable condition tree in Drupal core :P

Ok the reason for this is, that the conditionsForm isn't builded entirely correct, it doesn't apply the gathered contexts needed for some conditions.

In our case, it's missing the current user context. Because that context is missing, but it is set as an required context all conditions simply fail, and the JS isn't initialized properly.

Let's adjust the form building to how it is done in https://git.drupalcode.org/project/google_tag/-/blob/2.0.x/src/Form/TagC....

(Don't forget https://git.drupalcode.org/project/google_tag/-/blob/2.0.x/src/Form/TagC... and other potentially crucial code passages).

Alright! That was fast! Please review! The UI is wonderful now!

GREAT work @grevil!
I left some final comments. If it works fine now, this is ready to be committed.

If there's no core issue for a trait yet, please create one and add a small task to implement it. We'll need it in all the following modules (and similar modules will also benefit, e.g. google_tag!):

• https://www.drupal.org/project/asset_injector →
• https://www.drupal.org/project/etracker →
• https://www.drupal.org/project/facebook_pixel →
• https://www.drupal.org/project/google_tag →
• https://www.drupal.org/project/ouibounce_exit_modal →
• https://www.drupal.org/project/matomo →
• https://www.drupal.org/project/cookiebot →
• https://www.drupal.org/project/posthog →
• https://www.drupal.org/project/tab_title_attention →
• https://www.drupal.org/project/userlike →
• ... and a lot more! Maybe even core blocks!

I marked the most widely used ones.

So, all done! Please do a final review!

Resolved final threads.

Automatically closed - issue fixed for 2 weeks with no activity.