- Issue created by @albeorte
- ๐ฎ๐ณIndia vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect โ for more details and Security advisory coverage application checklist โ to understand what reviewers look for. Tips for ensuring a smooth review โ gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications โ , Application workflow โ , What to cover in an application review โ , and Tools to use for reviews โ .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool โ only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues โ .
- If you have not done it yet, you should run
- ๐ฎ๐ณIndia vishal.kadam Mumbai
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
- ๐ฎ๐ณIndia vishal.kadam Mumbai
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml voiceflow/ FILE: voiceflow/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES ---------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 251 characters 9 | WARNING | Line exceeds 80 characters; contains 144 characters 10 | WARNING | Line exceeds 80 characters; contains 139 characters 14 | WARNING | Line exceeds 80 characters; contains 152 characters 16 | WARNING | Line exceeds 80 characters; contains 84 characters 17 | WARNING | Line exceeds 80 characters; contains 120 characters 18 | WARNING | Line exceeds 80 characters; contains 121 characters 26 | WARNING | Line exceeds 80 characters; contains 241 characters 30 | WARNING | Line exceeds 80 characters; contains 239 characters 31 | WARNING | Line exceeds 80 characters; contains 183 characters 32 | WARNING | Line exceeds 80 characters; contains 125 characters 34 | WARNING | Line exceeds 80 characters; contains 132 characters 35 | WARNING | Line exceeds 80 characters; contains 123 characters 36 | WARNING | Line exceeds 80 characters; contains 100 characters 40 | WARNING | Line exceeds 80 characters; contains 170 characters 42 | WARNING | Line exceeds 80 characters; contains 142 characters ---------------------------------------------------------------------- FILE: voiceflow/config/schema/voiceflow.schema.yml ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 13 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------
2. FILE: voiceflow.module
/** * @file * Voiceflow. */
FILE: modules/voiceflow_index/voiceflow_index.module
/** * @file * Voiceflow Index. */
The usual description for a .module file is โHook implementations for the [module name] moduleโ, where [module name] is the module name given in the .info.yml file.
- ๐ช๐ธSpain albeorte
Hello @vishal.kadam,
I have already fix the problems with coding standards.
Thank you very much for your review.
- ๐ฎ๐ณIndia vishal.kadam Mumbai
Rest looks fine to me.
Letโs wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Thank you for your contribution and for your patience with the review process!
I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.
These are some recommended readings to help you with maintainership:
- Dries โ ' post on Responsible maintainers
- Maintainership โ
- Git version control system โ
- Issue procedures and etiquette โ
- Maintaining and responding to issues for a project โ
- Release naming conventions โ .
You can find more contributors chatting on Slack โ or IRC โ in #drupal-contribute. So, come hang out and stay involved โ !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review โ . I encourage you to learn more about that process and join the group of reviewers.I thank the dedicated reviewers as well.
- Assigned to apaderno
- Status changed to Fixed
2 days ago 11:04am 25 April 2025 Automatically closed - issue fixed for 2 weeks with no activity.