Boolean formatter behavior is unexpected

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
Changing tags per Issue tags field → and Issue tags -- special tags →

Working on it.

anish.ir → closed merge request !11185

Hey,

I have implemented the fix to ensure the Boolean field formatter properly displays FALSE when the value is empty. Previously, empty boolean fields were not rendered, which caused confusion for end users expecting a clear ✔ or ✖ (or any other format) output.

Changes Made:

• Updated BooleanFormatter.php to handle NULL values by defaulting them to FALSE.
• Ensured that empty boolean fields are now correctly displayed in Views or any other place too, where the field is is used.
• Refactored the logic to prevent skipped fields and improve code readability.

Commit: Link

Please review and test the patch to confirm expected behavior.
Let me know if any improvements are needed.

Thanks!

We need the code changes in the form of a merge request to be reviewed. Thank you.

My merge request was closed.

@anish.ir
What is wrong with returning before the foreach ?
The foreach is skipped when the field is empty, so the variable elements will always be empty.

    if ($items->isEmpty()) {
      return [['#markup' => $formats[$format][1]]];
    }

This I get and is and is an good improvement:
$value = !empty($item->value) ? (bool) $item->value : FALSE;

Hey @jorisclaes,

Thanks for the clarification!

I initially removed the $items->isEmpty() check because I added a fallback at the end:
return !empty($elements) ? $elements : [['#markup' => $formats[$format][1]]];

However, I now see that keeping the early return makes the logic clearer and more efficient, since it avoids even entering the loop when there are no field values.
I'll restore the $items->isEmpty() check and update the MR. Thanks for the feedback!

Also, while raising the MR against 11.x, it reflected around 1236 commits to be merged to the 11.x branch, so I think the 3505775-boolean-formatter-behavior branch needs a rebase to sync with the latest 11.x.

Please let me know, what's best here, to proceed further.
Thanks!

have not reviewed but #6 is correct.

Also if not already included but test coverage will be required.

Merge request is recreated

Hey,

The MR with the required changes have been raised. Please have a look.
Thanks !

Appears to be missing test coverage

@13

I don't have much experience with writing test for Drupal, if I forgot something plz let me know.

Thanks, left some small comments on the MR

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Thanks for the feedback @smustgrave,
I reverted out of scope changes

And added a comment that it is a fallback with FALSE as default value.

Feedback appears to be addressed

One question/nit on the MR.

I have checked the issue and applied fixes based on the MR feedback. I updated the code to cast to bool directly, as this handles both true and false cases. There is no need for a ternary operator in this situation. I have reverified the test, and it is passing as expected.

Additionally, I encountered linting failures for the existing code. I have addressed these issues, and the code now passes the linting checks. I am moving this back to Needs Review. Kindly review.

Feedback appears to be addressed.