- Issue created by @pfrenssen
- First commit to issue fork.
- Merge request !54Issue #3505768 by b_harold: Fixed PHPStan warnings in GraphQL Webform. → (Merged) created by Unnamed author
- 🇮🇳India ankitv18
Left some comment, please check.
see@ https://www.drupal.org/node/3407994 →
You have to use version_compare to avoid this error. - 🇮🇳India ankitv18
I would like to suggest to add minimum support of D10.3 and then we can avoid using deprecationHelper or version_compare then things will remain intact.
@pfrenssen Any thoughts ? - 🇧🇬Bulgaria pfrenssen Sofia
I agree, Drupal 10.2 is no longer supported so we can drop it and set Drupal 10.3 as the minimum version.
- 🇪🇨Ecuador b_harold
I have restored the latest changes and set Drupal 10.3 as the minimum required version. Let me know if any further adjustments are needed.
- 🇮🇳India ankitv18
Thanks @ b_harold,
Now you can move into review and mark all threads resolved on the MR. - 🇧🇬Bulgaria pfrenssen Sofia
This is looking great, thanks a lot! We can now configure PHPStan to not allow any failures and this is good to go.
-
pfrenssen →
committed 2722e3ab on 2.x authored by
b_harold →
Issue #3505768 by b_harold, pfrenssen, ankitv18: Fix phpstan warnings
-
pfrenssen →
committed 2722e3ab on 2.x authored by
b_harold →
Automatically closed - issue fixed for 2 weeks with no activity.