the plugins VoteResultFunction methods are not compatible with their parents FieldVoteResultBase methods

MR20 allows me to cast votes on my fields again.

I know @tr wants tests for this sort of stuff, however thats not something I know how to do. I've tried to figure it out countless times for various projects but cant seem to wrap my head around the concept of writing tests. Hopefully someone else can help out with that.

Yes, your MR is good. But it should also declare(strict_types=1) for all these files. We don't need tests for adding type hints.

Part of the problem here is that votingapi_widgets (and other modules) depends on votingapi, and everytime I make a change on votingapi I have to also try to make those same changes in all the dependent modules (I have maintainer privileges only on some of those dependent modules.) When they are all in the -dev stage they are going to be out of sync from time to time. Once votingapi gets a release then we can make a votingapi_widgets release that agrees with that specific votingapi release.

I do have the above changes done locally, but I haven't pushed them yet because I am busy working on a lot of modules trying to bring them all up to standards. I would like get the testing working and improved so that things like this typing issue show up immediately in the tests when votingapi gets changed. So in this case, a simple test of the plugins provided by this module would have flagged this problem, and many other problems that will show up as votingapi gets changed. So while a new test is not needed for the above change, a test of these plugins is really, really needed for long-term maintenance of this module.

Hey @loze, maybe you can comment on 📌 JavaScript coding standards Active ? Try out the patch and let me know if it works for you?

I did the work, but 6 months without a single comment from the community makes me think that no one cares about this module. If this module is important to you, maybe you can spend a few minutes giving feedback on the proposed fixes?

@tr, I just left a comment on that issue and marked it as RTBC. I cate about this module and currently use it on two sites and am happy to help you get a stable release out.

Automatically closed - issue fixed for 2 weeks with no activity.