- Issue created by @tr
- Status changed to Active
4 months ago 7:44pm 11 August 2024 - πΊπΈUnited States tr Cascadia
With the switch to GitLab CI, all the JavaScript coding standards are now reported from eslint.
See for example: https://git.drupalcode.org/project/votingapi_widgets/-/jobs/2410740There is an automated patch in the pipeline output that can fix all of these. HOWEVER, we really should fix the jQuery once issues first before we start messing with code style.
Reopening because this needs to be fixed for a D11 release.
- Status changed to Needs review
4 months ago 12:08am 31 August 2024 - πΊπΈUnited States tr Cascadia
That seems to have fixed all the issues.
I would appreciate a review of the Fix 'Prefer addEventListener to $.bind jquery/no-bind' changes and the Fix 'Prefer value to $.val jquery/no-val' changes