The ProjectIcon component should accept an image prop, or figure out its image internally

I'll work on this.

This is ready for a review.

@phenaproxima i merged the changes that you intended to into my existing MR.It's in a working state.I would request you to review the changes and maybe close the MR that you opened.
Thanks!

phenaproxima → closed merge request !705

Closed my MR, I agree we should only proceed with one.

But that said...what is the benefit of changing this so dramatically? The internal list of alt texts and image sources was, I think, actually a good design; forcing the parent components to pass all the props in makes more work for them, increases brittleness, and means ProjectIcon no longer adds much value.

I really like the idea of being able to do something like <ProjectIcon type="installed" /> and let it internally figure out how to display it. I just didn't want greenInstalled to be a valid type, because that's a leaky abstraction. "Should it be green or not" should be totally internal to ProjectIcon, which is what your MR implements, but at the cost of making the components think about all the other details too.

Can we change direction here and go back mostly to what we had, which was largely good, and just remove greenInstalled as a legitimate type value for ProjectIcon?

If we want to follow the approach that you suggested then i have made the changes accordingly.marking it NR again.

That looks great but I think there's one small bug...

Fixed my points.

No code objections anymore, and I didn't do much alteration on this patch, so I'm marking it tentatively RTBC.

much clean. very amaze. still references to gin in there directly, of course, but that's for another day... this gets us there.

Automatically closed - issue fixed for 2 weeks with no activity.