- Issue created by @rkoller
- ๐ฎ๐ณIndia utkarsh_33
I think there are a couple of issue which are related to the styling in particular to gin theme.@ phenaproxima. suggested a better way to solve a problem for styling in Change UI for the install queue to match bulk operations ๐ Change UI for the install queue to match bulk operations Active issue's
this comment. ๐ Change UI for the install queue to match bulk operations Active .
We can have discuss and come up with a solution so that all the styling issues can be solved using a finalised approach. - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
we can also solve those problems within the scope of the bulk action ui issue and close this issue. would also be fine with me. but just thought scope should be kept tight and this issue was an followup to โจ Communicated the status/state of a module in one of the upper corners of a module card Needs work
- ๐บ๐ธUnited States phenaproxima Massachusetts
After discussion with @utkarsh_33, postponing on ๐ Change UI for the install queue to match bulk operations Active .
- ๐บ๐ธUnited States phenaproxima Massachusetts
I am told that ๐ Change UI for the install queue to match bulk operations Active effectively fixes this one, and unblocks other styling fixes. Therefore, closing as a duplicate, but please reopen if I have closed this issue in error.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
i've tested in the latest state of 2.0.x and the problem illustrated in the issue summary still applies.
- Merge request !691#3498562: The styling of the new installed button is not inline in light and broken in dark mode โ (Merged) created by utkarsh_33
- ๐ฎ๐ณIndia utkarsh_33
The checkmark is not inline with what we want but that's because we are using the checkmark from Claro theme see this MR.I am not sure whether we do the same thing for the checkmark as well as we are doing for classes, so just keeping it as is for now until someone has thoughts on this.Marking it NR.
- ๐บ๐ธUnited States phenaproxima Massachusetts
The ID selector and use of Gin-specific hacks in the Svelte code is sad, but not the end of the world, and could be improved in a subsequent issue.
No objections from me, then, but leaving in the review state until it gets signed off on by @chrisfromredfin or @rkoller.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
the only pressing problem i see is the color contrast of the checkmark (rgb(85, 86, 91)) in dark mode against the background (rgb(59, 59, 63)) (only quickly used the color picker), the resulting contrast is 1.5:1, but it should have at least 3:1. other points would be styling and aesthetics related and the consistency in between light and dark mode and so on. but that could be moved to follow up issues.
- ๐บ๐ธUnited States phenaproxima Massachusetts
Looks like ESLint is still mad. Also, needs follow-ups. :)
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
I still have some FU to file for this - the styling is still off in Claro (like 2px height differential) but that's been there forever and is out of scope for this issue. And this is an improvement to dark mode / Gin and will help Drupal CMS. So, here goes!
-
chrisfromredfin โ
committed 291be59e on 2.0.x authored by
utkarsh_33 โ
Issue #3498562: The styling of the new installed button is not inline in...
-
chrisfromredfin โ
committed 291be59e on 2.0.x authored by
utkarsh_33 โ
Automatically closed - issue fixed for 2 weeks with no activity.