- Issue created by @Grimreaper
- π«π·France Grimreaper France π«π·
Providing MR as suggested in https://drupal.slack.com/archives/CGKLP028K/p1738081709999859
- Merge request !322Issue #3502879 by grimreaper: Build task fails on project without composer.json file β (Merged) created by Grimreaper
- π«π·France Grimreaper France π«π·
MR tested OK in https://git.drupalcode.org/project/ui_examples/-/jobs/4167786
- π¬π§United Kingdom jonathan1055
Interesting that you found this, as we mean to cater for projects without a composer.json file. An empty one is created earlier in the composer step, but maybe the logic is not quite right if you are having this problem.
- πͺπΈSpain fjgarlin
We create the backup file if the "composer.json" file is present only, but we forgot to test for this in the case of restoring the backup.
The MR fixes it and #5 proves that it works.
-
fjgarlin β
committed c1feabf8 on main authored by
grimreaper β
Issue #3502879 by grimreaper, jonathan1055, fjgarlin: Build task fails...
-
fjgarlin β
committed c1feabf8 on main authored by
grimreaper β
- π¬π§United Kingdom jonathan1055
The problem could have been introduced in the recent changes in π PHPCS error in contributed module caused by core recipe.README.txt Active
- πͺπΈSpain fjgarlin
I've merged this already. Thanks for reporting and helping with the MR and testing.
- π¬π§United Kingdom jonathan1055
From #7
We create the backup file if the "composer.json" file is present only, but we forgot to test for this in the case of restoring the backup.
The composer.json file is created empty if it does not exist. The actual cause of this problem is that no symlink was made for compsoer.json (quite correctly, as it happens now) but previosuly there would have always been the file there ready to delete.
The solution is good, anyway.
- πͺπΈSpain fjgarlin
Yup, agree it might have been brought by that issue, but yeah, the fix in https://git.drupalcode.org/project/gitlab_templates/-/commit/c1feabf8cac... makes sense.
- First commit to issue fork.
-
fjgarlin β
committed 777dc920 on main authored by
heddn β
Issue #3502879 by grimreaper, heddn, fjgarlin, jonathan1055: Build task...
-
fjgarlin β
committed 777dc920 on main authored by
heddn β
-
fjgarlin β
committed 11e1484e on main
#3502879: Changelog.
-
fjgarlin β
committed 11e1484e on main
- πͺπΈSpain fjgarlin
Crediting @bdragon for identifying and helping with the fix for D7.