Remove most writable stores from the global scope

Created on 28 January 2025, 2 months ago

Problem/Motivation

After πŸ“Œ Remove all remaining instance-specific constants from the Svelte code Active , we're in a better spot with regard to Project Browser's state management and what scope it exists in.

Right now, though, certain parts of its state are component-scoped, and other parts are globally scoped. That's not helpful, and prevents us from having multiple PB instances on one page.

Proposed resolution

Move most of the remaining writable stores in stores.js into the component scope.

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !694Move pageSize store into component scope β†’ (Merged) created by phenaproxima
  • Pipeline finished with Success
    2 months ago
    Total: 453s
    #408543
  • Pipeline finished with Success
    2 months ago
    Total: 774s
    #408552
  • Pipeline finished with Success
    2 months ago
    Total: 488s
    #408559
  • Pipeline finished with Success
    2 months ago
    Total: 705s
    #408572
  • Pipeline finished with Success
    2 months ago
    Total: 494s
    #408577
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Pretty straightforward. Nothing remains of stores.js -- good riddance.

    The only writable stores that are still global are the ones relating to the install queue, which remain global for the same reason that the MAX_SELECTIONS constant is.

  • πŸ‡ΊπŸ‡ΈUnited States tim.plunkett Philadelphia

    This is such a nice clean-up. Farewell stores.js!

  • Pipeline finished with Success
    2 months ago
    Total: 739s
    #408587
  • Pipeline finished with Skipped
    2 months ago
    #408664
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    Whoa.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 1439s
    #432364
  • Pipeline finished with Success
    about 1 month ago
    Total: 5075s
    #432404
  • Pipeline finished with Success
    about 1 month ago
    Total: 2601s
    #432532
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1323s
    #432834
  • Pipeline finished with Success
    about 1 month ago
    Total: 1127s
    #432983
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1248s
    #432996
  • Pipeline finished with Success
    about 1 month ago
    Total: 2184s
    #433008
  • Pipeline finished with Failed
    about 1 month ago
    Total: 622s
    #433108
  • Pipeline finished with Failed
    about 1 month ago
    Total: 445s
    #433110
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1272s
    #433113
  • Pipeline finished with Success
    about 1 month ago
    Total: 2445s
    #433123
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 67s
    #433383
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 119s
    #433385
  • Pipeline finished with Success
    about 1 month ago
    Total: 1351s
    #433387
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1195s
    #433432
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1212s
    #433458
Production build 0.71.5 2024