Contrib.social

Remove all remaining instance-specific constants from the Svelte code

Open on Drupal.org →
Created on 27 January 2025, 9 days ago

Problem/Motivation

Our north star, currently, is to get the Svelte code to a place where it could show multiple project browsers on a single page. We're not far from that goal. Some of the most egregious spaghetti code is now untangled.

The best indicator that the current architecture would be amenable to multiple-PBs-on-a-page is the Svelte app's constants.js. These constants, by design, are for things that apply to the entire page -- to every project browser. Anything instance-specific shouldn't be in one of these constants.

So, in this issue, let's remove the remaining instance-specific constants. Those are SORT_OPTIONS, DEFAULT_SOURCE_ID, ACTIVE_PLUGIN, and FILTERS.

(MAX_SELECTIONS could be considered instance-specific, but also kinda not. That has implications that need to be worked out in subsequent issues, so I'll leave it as-is for now.)

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !689Resolve #3502645 "Remove all remaining" → (Merged) created by phenaproxima
  • Pipeline finished with Canceled
    9 days ago
    Total: 344s
    #407697
  • Pipeline finished with Success
    9 days ago
    Total: 393s
    #407700
  • Pipeline finished with Failed
    9 days ago
    Total: 464s
    #407709
  • Pipeline finished with Success
    9 days ago
    Total: 447s
    #407715
  • Pipeline finished with Success
    9 days ago
    Total: 602s
    #407731
  • Pipeline finished with Canceled
    9 days ago
    Total: 388s
    #407739
  • Pipeline finished with Success
    9 days ago
    Total: 398s
    #407747
  • Pipeline finished with Failed
    9 days ago
    Total: 471s
    #407772
  • Pipeline finished with Failed
    9 days ago
    Total: 383s
    #407785
  • Pipeline finished with Success
    8 days ago
    Total: 447s
    #407814
  • Pipeline finished with Success
    8 days ago
    Total: 458s
    #407822
  • Pipeline finished with Failed
    8 days ago
    Total: 343s
    #407840
  • Pipeline finished with Success
    8 days ago
    Total: 369s
    #407843
  • Pipeline finished with Success
    8 days ago
    Total: 471s
    #407859
  • Pipeline finished with Failed
    8 days ago
    Total: 727s
    #407864
  • Pipeline finished with Failed
    8 days ago
    Total: 222s
    #407873
  • Pipeline finished with Success
    8 days ago
    Total: 356s
    #407875
  • Pipeline finished with Success
    8 days ago
    Total: 815s
    #407883
  • Pipeline finished with Success
    8 days ago
    Total: 1015s
    #408287
  • Pipeline finished with Success
    8 days ago
    Total: 1000s
    #408323
  • First commit to issue fork.
  • Pipeline finished with Success
    8 days ago
    Total: 372s
    #408379
  • Pipeline finished with Skipped
    8 days ago
    #408397
  • Comment 8 days ago →
    System Message
  • Comment 8 days ago →
    🇺🇸United States phenaproxima Massachusetts

    And that's that. Thanks @chrisfromredfin!

  • Comment 8 days ago →
    🇺🇸United States chrisfromredfin Portland, Maine

    [p.s. Reviewed this with Adam over Zoom, tested thoroughly manually. No changes with the exception of keeping the Clear/Recommended links present always, which was previously discussed.

    Follow-up coming on whether or not that's the better UI, or if it can be improved in a different way. But it was taken for the pro of it being less/easier code.]

  • Comment 8 days ago →
    🇺🇸United States chrisfromredfin Portland, Maine
  • Comment 8 days ago →
    🇺🇸United States phenaproxima Massachusetts
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024