Call to undefined method ::isSyncing() during push on certain entities

I'm attaching a patch to resolve the issue for salesforce 5.1.1

This is fine for now, but imo we should enforce implementation of SynchronizableInterface in order for entities to be mappable.

I see you're mapping a custom object, why not just implement the interface?

prem suthar → made their first commit to this issue’s fork.

@aaronbauman:

I see you're mapping a custom object, why not just implement the interface?

Because it's not my code. It's a contrib. We cannot tell contrib developers to please implement the SynchronizableInterface interface for all custom entities to make sure that the Salesforce Suite module does not break :) It's the Salesforce module's responsibility to make sure that the methods and functions it's using (either from core or from other contribs) are available and callable.

Because it's not my code. It's a contrib

Well, yes, i guess that would do it.

I can't think of a reason why an entity would not be either config or content, but I guess they've found one.
You're right, there's no reason we should prevent this kind of entity from being mapped.

However, a word of caution: in terms of the motivation for isSyncing() - this check is designed to prevent push-pull feedback loops between Drupal and Salesforce. I'm not inclined to implement a workaround inside the module for this edge case, but something you'll want to watch out for.

aaronbauman → changed the visibility of the branch 3502753-call-to-undefined to hidden.

committed, thanks

@aaronbauman Thank you very much for the commit and in general for your thoughts about this problem.

Automatically closed - issue fixed for 2 weeks with no activity.