- Issue created by @dxvargas
- Merge request !188Issue #3502496: Only continue js routines when ajax is successful. β (Merged) created by dxvargas
- π΅πΉPortugal dxvargas
I'm proposing a minimal change that does the trick. This situation is not common to happen, so I don't think we should put too much code for it.
Actually my proposal seems like what should be there is first place. If there is an error it doesn't make sense to continue the javascript routines.
- π΅π±Poland alorenc Wolsztyn, π΅π±
This has some side effects. If I log in again inside the second tab, the system will no longer update messages in the first tab.
I don't know which option is better - π΅πΉPortugal dxvargas
Thanks for the review @alorenc! I've updated the MR with your suggestions.
If I log in again inside the second tab, the system will no longer update messages in the first tab.
Yes true, but the user sees error messages, so the fact that the page is not working shouldn't be a surprise.
Maybe the error message could be improved. Not it shows " Oops, something went wrong. Check your browser's developer console for more details.". But I would first fix this problem and then improve the UI if necessary.
- π΅π±Poland alorenc Wolsztyn, π΅π±
Looks fine, Ajax calls do not generate infinite errors.
- π·π΄Romania claudiu.cristea Arad π·π΄
claudiu.cristea β made their first commit to this issueβs fork.
-
claudiu.cristea β
committed 13167255 on 4.x authored by
dxvargas β
Issue #3502496 by dxvargas, alorenc: Countless errors after logout if a...
-
claudiu.cristea β
committed 13167255 on 4.x authored by
dxvargas β
- π·π΄Romania claudiu.cristea Arad π·π΄
Thank you for report & fix
Automatically closed - issue fixed for 2 weeks with no activity.