- Issue created by @Greg Boggs
- First commit to issue fork.
- Merge request !495Changed the feature image format thumbnail to render for event card display mode. → (Merged) created by prabha1997
- 🇺🇸United States Greg Boggs Portland Oregon
Tested this on a fresh install and it works as expected. Final image file for the DrupalCon event is 31.5kb when displayed on the homepage and the card mode now displays perfectly on the home page.
- 🇺🇸United States phenaproxima Massachusetts
No code objections, but needs a change record so that existing sites know how to make this change for themselves.
Please use this link → to add one, and you can use this template if you need guidance.
An example: https://www.drupal.org/node/3505554 →
- 🇺🇸United States phenaproxima Massachusetts
OK, quick question here.
I tried to manually test this to see what visual change there is, if any, but I can't figure out how to do that. Sounds weird, but hear me out -- if I follow the steps to reproduce in the issue summary, that describes a performance difference, but not a visual difference.
How does this bug manifest to users? Does it cause any visual change? The issue talks about a listing of Page cards, but where do we even have that? As far as I know, there is no card listing of basic pages.
Can this get clearer steps to reproduce so I can actually see this bug happening, without needing to open dev tools?
- 🇺🇸United States Greg Boggs Portland Oregon
The display is visually the same between a webp image and png image. But, the PNG image is 1.3 megabytes, and the webp image is 31.5kb.
The way I found it was I:
- installed all the recommended recipes
- opened inspect element
- opened the network tab
- loaded the page
- clicked sort on the "size" column twice so the large items appear at the top.
That's where the 1 mb+ image shows up.
- 🇺🇸United States phenaproxima Massachusetts
Okay, gotcha.
So that means I gotta retitle this issue for clarity and update the issue summary with the proper steps to reproduce. :) The "page content type card" mention is red herring - correct?
Not sure why that was there.
- 🇺🇸United States phenaproxima Massachusetts
Probably also makes sense to have a small regression test here.
- 🇺🇸United States Greg Boggs Portland Oregon
Yep, Yep. The new title is much more accurate.
For end users an extra 1MB event image is only really noticeable for folks on slower internet.
The Drupal.org home page has an incorrectly saved png file that's 600kb and I can't visually see it when I load the page because my Internet is fast.
- 🇺🇸United States phenaproxima Massachusetts
Wrote some simple regression tests for all the content types.
- 🇺🇸United States phenaproxima Massachusetts
Manually tested and confirmed that there is no apparently visual regression, and a huge size improvement on that thumbnail image.
-
phenaproxima →
committed 7268ec6a on 1.x authored by
prabha1997 →
Issue #3502066 by prabha1997, phenaproxima, greg boggs: The Event card...
-
phenaproxima →
committed 7268ec6a on 1.x authored by
prabha1997 →
-
phenaproxima →
committed 9b3d36aa on 1.0.x authored by
prabha1997 →
Issue #3502066 by prabha1997, phenaproxima, greg boggs: The Event card...
-
phenaproxima →
committed 9b3d36aa on 1.0.x authored by
prabha1997 →
- 🇺🇸United States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x. Thanks, everyone!
Automatically closed - issue fixed for 2 weeks with no activity.