Make noUISlider module/lib a soft dependency

Created on 24 January 2025, 2 months ago

Problem/Motivation

Hello, I noticed that Create a mirror for external library dependencies for composer support Active introduced a new nouislider_js module as a hard dependency in composer.
Couldn't we make it a soft dependency, or use the npm-asset method that a lot of modules are now adopting?
https://www.drupal.org/docs/develop/using-composer/manage-dependencies#t...

Steps to reproduce

N/A

Proposed resolution

TBD

Remaining tasks

?

User interface changes

?

API changes

?

Data model changes

?

Feature request
Status

Active

Version

7.0

Component

Code

Created by

🇧🇪Belgium herved

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @herved
  • 🇺🇸United States smustgrave

    So I’m inclined to keep this as is. If someone forgets to get the library then I’ll get more tickets about the slider not working. Don’t see the harm in downloading the library

    Leaning toward won’t fix

  • 🇧🇪Belgium herved

    It was just an idea, since I saw there was a lot of effort to remove all the jquery_ui dependencies recently.
    Some modules also add a requirement message in the status page in case the library is missing.
    And composer can handle library updates when using the npm-asset method (or composer-merge plugin).
    Here is an example from js-cookie Support local library file Active

    But feel free to close it if no-one else objects.

  • 🇺🇸United States smustgrave

    Definitely appreciate the suggestion. Demonstrate a better noui slider library integration. Active we are going to clean up slightly so it just uses the mirror copy. So CDN should be removed so hopefully that addresses any concern.

Production build 0.71.5 2024