Add return type to remaining hook implementations

Updated the following:

Drupal\search_langcode_test\Hook\SearchLangcodeTestHooks::searchPreprocess
Drupal\comment\Hook\CommentHooks::nodeUpdateIndex
claro_views_pre_render
contextual_preprocess
deprecation_test_deprecated_hook
module_test_altered_test_hook
module_test_modules_installed
module_test_modules_uninstalled
module_test_test_hook
nyan_cat_extension
nyan_cat_render_template
test_subtheme_views_post_render
test_subtheme_views_pre_render
twig_extension
twig_render_template

I'm sure someone with better grep-fu will find some I've missed.

Left 1 comment on MR.

Meant to keep in review.

Also where does it return stringable?

@smustgrave a lot of the time where we had @return string we're actually getting a MarkupInterface (e.g. TranslatableMarkup) but since we don't have strict types in runtime code yet it gets coerced to a string. Once example is twig_render_template. We could be more prescriptive and use MarkupInterface instead of Stringable, but I think we should allow both. Besides, implementations can return whatever they want, the hooks in .api.php files are just examples.

Thanks for the explanation. That was my only comment/concern.

Since this is to be the last, I am postponing on the sibling issues.

I'm sure this needs a rebase, I don't agree this needs postponing.

It says remaining meaning hooks that don't have another issue, not remaining as in all others have to be in first.
I updated the title to reflect that.

I agree with #11, we're not depending on this to enable a phpcs rule so if there happens to be any that are missed they can go in their own issue.

Rebased

Looks good to me again, rebase seems clean.

@nicxvan, thanks for updating the title.

Committed 7488aea and pushed to 11.x. Thanks!

quietone → closed merge request !10994

Automatically closed - issue fixed for 2 weeks with no activity.