- Issue created by @pameeela
- π¬π§United Kingdom dunx
Steps to reproduce:
- git clone https://git.drupalcode.org/project/drupal_cms.git
- cd drupal_cms
- ddev config --project-type=drupal11 --docroot=web --php-version=8.3
- ddev start
- ddev composer install
- ddev launch
Skipped majority of config (no option to install SEO Recipe anyway).
Applied SEO tools recipe:
- This wasn't presented as an option on installation for dev, which confused me and it took a while (far too long in fact as the "commands" shown didn't work not matter what paths I was using under ddev) to figure out how to install it using the
drupal
script. - I installed drush and from web, ran
ddev drush recipe ../recipes/drupal_cms_seo_tools -v
View page source:
- Plenty of og and twitter tags present so recipe is installed.
- Both og:description and twitter:description are missing, presumably because they have null values before the patch.
Removed container, to start again, so repeated all of the above with the above recipe patched before I installed it.
View page source:
- Both og:description and twitter:description now have the vale "This is the home page of your new site. Start by editing this page, or creating new pages.".
All looks good to me.
- πΊπΈUnited States phenaproxima Massachusetts
I think we probably need to update the test coverage for this to ensure it doesn't regress later.
- π¦πΊAustralia pameeela
@phenaproxima annoying that we have really good test coverage of the meta tags but the front page requires separate config. Should we try to replicate this coverage for home? Or just quickly check for the values?
Either way would be good to get this fix in for 1.0.1 and follow up with tests.
- π¦πΊAustralia pameeela
Created π Add test for front page meta tags Active for adding tests.
-
phenaproxima β
committed 3402b6fe on 1.x authored by
pameeela β
Issue #3500805 by pameeela, dunx: Front page meta description still...
-
phenaproxima β
committed 3402b6fe on 1.x authored by
pameeela β
- πΊπΈUnited States phenaproxima Massachusetts
Merged into 1.x and cherry-picked to 1.0.x. Thanks!
-
phenaproxima β
committed ea3e3858 on 1.0.x authored by
pameeela β
Issue #3500805 by pameeela, dunx: Front page meta description still...
-
phenaproxima β
committed ea3e3858 on 1.0.x authored by
pameeela β
- πΊπΈUnited States phenaproxima Massachusetts
Release notes are now handled via change records.
- πΊπΈUnited States phenaproxima Massachusetts
Created the change record, it just needs details filled in. https://git.drupalcode.org/project/drupal_cms/-/wikis/Committer-Info/Cha... can be used as a template.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Screenshot added to change record.
- Status changed to Fixed
5 days ago 9:44pm 1 April 2025 Automatically closed - issue fixed for 2 weeks with no activity.