- Issue created by @zigazou
- 🇧🇷Brazil renatog Campinas
Good catch! Makes sense!
Could someone create a merge request with the same fix of this patch, please?
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →
With that we can merge easily though the GitLab UI, you know?
- Merge request !61Issue #3272848 by RenatoG: When the error appear the field is hidden and the... → (Merged) created by dhruv.mittal
I have converted patch to MR. And there was merge conflict so also resolved that.
still there are some tests failing but I think those should be resolved in separate issue.- 🇮🇳India adwivedi008
@dhruv.mittal
Can you please check again, the MR against which version you are creating the MR I guess it should be created against 4.0.x and the branch should also be taken from 4.0.x
Moving this issue to Needs work as there are more than 200 commits in MR - 🇮🇳India adwivedi008
MR 61 seems fine to me
tested on vanilla Drupal and now buttons are translatable
Moving the issue to RTBC -
renatog →
committed 10077bc4 on 4.0.x authored by
dhruv.mittal →
Issue #3500641: Some button labels are not translatable
-
renatog →
committed 10077bc4 on 4.0.x authored by
dhruv.mittal →
Automatically closed - issue fixed for 2 weeks with no activity.