- Issue created by @pcambra
- πͺπΈSpain pcambra Asturies
pcambra β changed the visibility of the branch 8.x-1.x to hidden.
- πΊπΈUnited States tr Cascadia
I just now changed the GitLabCI testing configuration to test against max PHP, so these sorts of things should now be flagged by testing. Likewise, we can now see whether MRs like this fix all the errors of this type, because the testing will catch it if the MR misses a case.
Note that the above MR does flag a typing error which should be fixed.
- First commit to issue fork.
- π¦πΉAustria klausi π¦πΉ Vienna
Updated pull request.
Here also as static file for composer.patches.json
- πΊπ¦Ukraine andriy khomych
I checked the above patch and MR.
In my opinion, it is fine.
Moved to RTBC. - First commit to issue fork.
-
berdir β
committed 276e51fc on 8.x-1.x authored by
pcambra β
Issue #3500327 by pcambra, klausi: Nullable types must be explicit
-
berdir β
committed 276e51fc on 8.x-1.x authored by
pcambra β
- π¦πΉAustria klausi π¦πΉ Vienna
Thank you!
I can haz new release?
I'll get you a drink at Mountaincamp :)
Automatically closed - issue fixed for 2 weeks with no activity.