- Issue created by @Anybody
- 🇩🇪Germany SteffenR Germany
Hi Julian,
Thanks for the issue.
Since the module is already passing the parameters via POST only the auth_key needs to be changed and authorization needs to be done via the Authorization header. - Merge request !32#3500306: Change Notice: Upcoming deprecations in DeepL API → (Merged) created by SteffenR
- 🇩🇪Germany Anybody Porta Westfalica
Thank you very very much @steffenr! :) Going to review this ASAP!
- 🇩🇪Germany Anybody Porta Westfalica
LGTM! I didn't try it myself yet, just reviewed the code. Due to the API changes in the hooks this will need at least a minor, if not even major release for compatibility with eventual custom modules?
I very much like the new array implementation!
Fixes for the deprecations also look fine.Please decide to wait for further feedback from people who already tested the running code, set back to Needs review then.
Great work!!
- 🇨ðŸ‡Switzerland ayalon
Thanks a lot for the work and the merge request.
@anybody: Apart from reviewing the code, I also have tested the functionality on a live system and successfully translated nodes and other things with TMGMT with a Deepl Pro API key.I did not encounter any issues.
The MR can be considered as reviewed and tested.
- 🇩🇪Germany SteffenR Germany
@ayalon: Thanks for further testing. I also did some test in more complex setups on our site.
I'll prepare a new release for the module.
-
steffenr →
committed 63a72c60 on 2.2.x
#3500306: Change Notice: Upcoming deprecations in DeepL API
-
steffenr →
committed 63a72c60 on 2.2.x
Automatically closed - issue fixed for 2 weeks with no activity.