HEAD broken with asserts enabled

Note I've also bundled this into 📌 [PP-1] Send page data to Drupal for storage in auto-save store Postponed: needs info

😱

This suggests that assertions are disabled on CI somehow?!? We ran into this months ago IIRC.

That would be a crucial thing to restore on CI 😬

Both \XbConfigEntityHttpApiTest::testPattern() and \PropSourceEndpointTest() cause \Drupal\experience_builder\ClientSideRepresentation::renderPreviewIfAny() to be executed.

I'm shocked that this somehow regressed. 🤪

Note: this would also mean that core's \Drupal\jsonapi\EventSubscriber\ResourceResponseValidator::onResponse() will never actually verify JSON:API response shape compliance, and the same thing would be true for XB's OpenAPI request + response body OpenAPI compliance! 😱😱😱

Aha, you created 📌 PHP asserts not running in CI/during tests Active for that. Moving #7 + #8 there …

Root cause identified: #3500110-5: PHP asserts not running in CI/during tests → — regression in Drupal core (and CI) from >1 year ago. So must never have been fixed. 😭 But at least it used to work locally.

I really want to make CI fail before merging this. Because I do not want to run into this problem ever again. That is happening over at 📌 Remove mentions of assert.active from .htaccess Needs work 👍

First landing 📌 PHP asserts not running in CI/during tests Active now that together with @longwave we figured out a way to work around the core regression, and get back assertions during CI runs 👍

I'm going to scope this down to only the PHP assertions failures. I'll land your individual issues/MRs instead, because: A) they exist, B) that makes the history clearer, C) most of those issues provide valuable additional context.

📌 PHP asserts not running in CI/during tests Active is in, which means 0.x should now fail hard.

Meanwhile, rebasing this on 0.x and omitting E2E test hardening from this MR, to make 0.x green again 👍

As expected:

• 0.x is failing across the board now that 📌 PHP asserts not running in CI/during tests Active is in: https://git.drupalcode.org/project/experience_builder/-/pipelines/397641
• this MR makes those tests pass: https://git.drupalcode.org/project/experience_builder/-/jobs/4039944

Everything is sane again! ☺️🥲

Thank you @larowlan and @wim leers for fixing this so quickly 🙏

And @longwave! Without @longwave, 📌 PHP asserts not running in CI/during tests Active would not have landed, without which we'd risk re-introducing bugs such as this one!