Query results are case sensitive when sorting alphabetically

We use Composer so adding a patch file for easier local testing.

@tdroden

I have review MR !10909 in Drupal Core 11.x-dev and it's working for me.

So i am moving this issue to RTBC.

Thank you!!

Patch from the latest MR, tested.

Work is needed. Test coverage is required. I have edited the issue summary removing unnecessary text. But further update is required. Added tags for these things.

@oily I have updated the test steps in the original description. I walked through these steps using simplytest.me and was able to produce the screen capture. Please let me know if further clarification is required.

@tdroden Looks good. We need to fork from the 11.x-dev branch. Any changes to 10.x will be backported from 11.x-dev. I am not certain that this will need a PHPUNIT test. I am removing the tags and changing to 'Needs review'. The reviewer will hopefully decide if PHPUnit test coverage is needed.

oily → changed the visibility of the branch 10.2.x to hidden.

Created an 11.x branch. Copied the the 10.x MR changes to the new MR.

Rebased 11.x MR

Probably will need test coverage as well.

I haven't encountered this issue i checked on drupal 11.x, uploaded screenshot for reference

Not really sure what to do here then.

I just used simplytest.me and spun up an install of Drupal 11.1.2. (I was running into dependency issues trying to build with Devel in the mix, so just used a basic install and manually created 50 menu entries.)

Using my test steps above, I was able to replicate that this is indeed happening in D11 (as well as D10) - once enough menu entries exist to trigger pagination (screenshot attached).

Since uasort hits the comparer function more than once for each element https://3v4l.org/lYob3 I thought I would recommend assembling the array ahead of the time and then use natcasesort instead, something like

      $result = array_map(function ($a) use ($field) {
        foreach (explode('.', $field) as $property) {
          $a = $a[$property] ?? NULL;
        }
      }, $result);
      natcasesort($result);

but I can't recommend this because I do not understand the current code at all. I am looking at a07a4ba051 from #2942569: Sorting nested properties of config entity queries does not work → and I still don't understand it. Say there are some third party settings you are sorting on, one config object doesn't have them then one half of this loop becomes NULL the other half becomes a something and then you are trying to sort NULL to something? What is even the desired sort outcome of this? I will link this question to the authors of the current codebase to see whether we can do something.