Improve vertical tabs display

Created on 11 January 2025, 9 days ago

Vertical tabs look like they're rendering with default styles and aren't looking right within Daisy UI.

πŸ“Œ Task
Status

Active

Version

4.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mortona2k
  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    This is a tricky component to override.

    Prose styles were applying to the ul. To add .no-prose, I had to override vertical-tabs.js from core, since the element is built in the script.

    It may also be possible to override that in tailwind settings or css.

    I added a details template, with an m-4 class. But I think we should use the daisyui component: https://daisyui.com/components/collapse/#collapse-using-details-and-summ...

    vertical-tabs.css in core has some styles that need to be overridden, like the active tab color.

    I used @apply in a custom css library. How do we unite the custom library with the contrib theme? I think we need to set up a default package.json in there, with the extra customizations. Looks like we're just shipping dist right now.

    For now, I copied the generated css into custom.css.

    Tabs could use the tab or button components.

    Color choices up for debate.

  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    Claro only shows accordion style tabs, and is used in the node form layout.

    Stark shows the vertical tabs details summary as hidden. That's exposed by the .collapse class.

    Extra CSS needed to override, added to custom.css.

  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    Vertical tabs are really weird. When the page is loaded, they decide whether to render horizontally.

    They don't switch displays on window resize.

    Currently the mobile version is unstyled, but should be using the details element, so that needs a border style, and I'm not seeing a collapse icon.

  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle
Production build 0.71.5 2024