- Issue created by @unqunq
- 🇬🇧United Kingdom unqunq
I had a bit more left to do on this so I added it this morning. Would you be kind to test again?
- 🇬🇧United Kingdom MrDaleSmith
You've got failing PCS issues, and I personally don't like the idea of the permission change: this means that a menu item where you can't do anything will appear in your admin menu. I appreciate that's so you can show the message on the page, and that the maintainers may decide that's a better UX. Have you checked whether that custom access check is being used anywhere else? Because if it isn't, the code probably wants removing as well.
- 🇬🇧United Kingdom unqunq
I think that not seeing the menu item and therefore not displaying the message will not help users understand that a model needs to be added. Maybe the maintainers can add their view on this as well.
The access check class might not be used elsewhere indeed so I can remove it as well once we get the confirmation that this is the way to go.
- 🇬🇧United Kingdom MrDaleSmith
Actually - the changes you're making don't appear to relate to the description of this ticket, and are duplicating work in https://www.drupal.org/project/ai/issues/3499412 📌 Make selection of AI Provider clearer on module homepage Active - it might be better to remove them completely so this ticket can be closed and then address the other issue on its ticket.
- 🇬🇧United Kingdom unqunq
Trying to do things in a rush this morning before work (and before coffee ;)...
Let's merge this one.